linux-kernel - Re: [PATCH] kernel-doc: be case insensitive when removing attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100819085710.fe790810.rdunlap@xenotime.net>
Date:	Thu, 19 Aug 2010 08:57:10 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel-doc: be case insensitive when removing
 attributes

On Thu, 19 Aug 2010 16:13:42 +0200 Johannes Berg wrote:

> From: Johannes Berg <johannes.berg@...el.com>
> 
> There are valid attributes that could have upper
> case letters, but we still want to remove, like
> for example
> 	__attribute__((aligned(NETDEV_ALIGN)))
> as encountered in the wireless code.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
> I thought we did this before? Bit confused now :)

I have a similar patch, without patch description & signoff,
so maybe it was from irc.  Oh, and it's in a different script location.

@@ -1426,6 +1426,7 @@ sub dump_struct($$) {
 	$members =~ s/kmemcheck_bitfield_.*?;//gos;
 	# strip attributes
 	$members =~ s/__aligned\s*\(\d+\)//gos;
+	$members =~ s/__attribute__\s*\(\([a-zA-Z,_()\s\*]*\)\)//gos;


If yours (below) does what is needed, that's fine with me.

>  scripts/kernel-doc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- wireless-testing.orig/scripts/kernel-doc	2010-08-19 16:11:40.000000000 +0200
> +++ wireless-testing/scripts/kernel-doc	2010-08-19 16:11:45.000000000 +0200
> @@ -1679,7 +1679,7 @@ sub check_sections($$$$$$) {
>  		foreach $px (0 .. $#prms) {
>  			$prm_clean = $prms[$px];
>  			$prm_clean =~ s/\[.*\]//;
> -			$prm_clean =~ s/__attribute__\s*\(\([a-z,_\*\s\(\)]*\)\)//;
> +			$prm_clean =~ s/__attribute__\s*\(\([a-z,_\*\s\(\)]*\)\)//i;
>  			# ignore array size in a parameter string;
>  			# however, the original param string may contain
>  			# spaces, e.g.:  addr[6 + 2]
> 
> 
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/