linux-kernel - RE: [PATCH] Fixes field names that changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Aug 2010 19:16:28 -0500
From:	"Aguirre, Sergio" <saaguirre@...com>
To:	"henrique@...riquecamargo.com" <henrique@...riquecamargo.com>,
	Mauro Carvalho Chehab <mchehab@...radead.org>
CC:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	"Karicheri, Muralidharan" <m-karicheri2@...com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Fixes field names that changed

Hi Henrique,

Just some minor comments about the patch description below:

> -----Original Message-----
> From: linux-media-owner@...r.kernel.org [mailto:linux-media-
> owner@...r.kernel.org] On Behalf Of Henrique Camargo
> Sent: Tuesday, August 17, 2010 9:35 AM
> To: Mauro Carvalho Chehab
> Cc: Guennadi Liakhovetski; Karicheri, Muralidharan; linux-
> media@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] Fixes field names that changed

Add missing subject prefix to quickly describe the affected driver:

Subject: [PATCH] mt9t032: Fixes field names that changed

> 
> If CONFIG_VIDEO_ADV_DEBUG was set, the driver failed to compile because
> the fields get_register and set_register changed names to s_register and
> s_register in the struct v4l2_subdev_core_ops.

Please break down this comment to 70 chars max.

Also, you said "s_register" twice.

Regards,
Sergio

> 
> Signed-off-by: Henrique Camargo <henrique@...riquecamargo.com>
> ---
>  drivers/media/video/mt9t031.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c
> index 716fea6..f3d1995 100644
> --- a/drivers/media/video/mt9t031.c
> +++ b/drivers/media/video/mt9t031.c
> @@ -499,8 +499,8 @@ static const struct v4l2_subdev_core_ops
> mt9t031_core_ops = {
>  	.g_ctrl	= mt9t031_get_control,
>  	.s_ctrl	= mt9t031_set_control,
>  #ifdef CONFIG_VIDEO_ADV_DEBUG
> -	.get_register = mt9t031_get_register,
> -	.set_register = mt9t031_set_register,
> +	.g_register = mt9t031_get_register,
> +	.s_register = mt9t031_set_register,
>  #endif
>  };
> 
> --
> 1.7.0.4
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/