linux-kernel - [PATCH 3/3] writeback: Reporting dirty thresholds in /proc/vmstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Aug 2010 13:57:27 -0700
From:	Michael Rubin <mrubin@...gle.com>
To:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org
Cc:	jack@...e.cz, riel@...hat.com, akpm@...ux-foundation.org,
	david@...morbit.com, npiggin@...e.de, hch@....de, axboe@...nel.dk,
	Michael Rubin <mrubin@...gle.com>
Subject: [PATCH 3/3] writeback: Reporting dirty thresholds in /proc/vmstat

The kernel already exposes the desired thresholds in /proc/sys/vm with
dirty_background_ratio and background_ratio. Instead the kernel may
alter the number requested without giving the user any indication that
is the case.

Knowing the actual ratios the kernel is honoring can help app developers
understand how their buffered IO will be sent to the disk.

	$ grep threshold /proc/vmstat
	nr_pages_dirty_threshold 409111
	nr_pages_dirty_background_threshold 818223

Signed-off-by: Michael Rubin <mrubin@...gle.com>
---
 include/linux/mmzone.h |    2 ++
 mm/vmstat.c            |    8 ++++++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index f160481..7c4a3bf 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -114,6 +114,8 @@ enum zone_stat_item {
 #endif
 	NR_PAGES_ENTERED_WRITEBACK, /* number of times pages enter writeback */
 	NR_FILE_PAGES_DIRTIED,      /* number of times pages get dirtied */
+	NR_PAGES_DIRTY_THRESHOLD,   /* writeback threshold */
+	NR_PAGES_DIRTY_BG_THRESHOLD,/* bg writeback threshold */
 	NR_VM_ZONE_STAT_ITEMS };
 
 /*
diff --git a/mm/vmstat.c b/mm/vmstat.c
index e177a40..8b5bc78 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -17,6 +17,7 @@
 #include <linux/vmstat.h>
 #include <linux/sched.h>
 #include <linux/math64.h>
+#include <linux/writeback.h>
 
 #ifdef CONFIG_VM_EVENT_COUNTERS
 DEFINE_PER_CPU(struct vm_event_state, vm_event_states) = {{0}};
@@ -742,6 +743,8 @@ static const char * const vmstat_text[] = {
 #endif
 	"nr_pages_entered_writeback",
 	"nr_file_pages_dirtied",
+	"nr_pages_dirty_threshold",
+	"nr_pages_dirty_background_threshold",
 
 #ifdef CONFIG_VM_EVENT_COUNTERS
 	"pgpgin",
@@ -901,6 +904,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos)
 #ifdef CONFIG_VM_EVENT_COUNTERS
 	unsigned long *e;
 #endif
+	unsigned long dirty_thresh, dirty_bg_thresh;
 	int i;
 
 	if (*pos >= ARRAY_SIZE(vmstat_text))
@@ -918,6 +922,10 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos)
 		return ERR_PTR(-ENOMEM);
 	for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++)
 		v[i] = global_page_state(i);
+
+	get_dirty_limits(&dirty_thresh, &dirty_bg_thresh, NULL, NULL);
+	v[NR_PAGES_DIRTY_THRESHOLD] = dirty_thresh;
+	v[NR_PAGES_DIRTY_BG_THRESHOLD] = dirty_bg_thresh;
 #ifdef CONFIG_VM_EVENT_COUNTERS
 	e = v + NR_VM_ZONE_STAT_ITEMS;
 	all_vm_events(e);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/