linux-kernel - Re: [PATCH 001/001] USB: ftdi_sio: fix endianess of max packet size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100819144620.e078fbbe.akpm@linux-foundation.org>
Date:	Thu, 19 Aug 2010 14:46:20 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Michael Wileczka <mikewileczka@...oo.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 001/001] USB: ftdi_sio: fix endianess of max packet size

On Wed, 18 Aug 2010 07:14:37 -0700 (PDT)
Michael Wileczka <mikewileczka@...oo.com> wrote:

> From: Michael Wileczka <mikewileczka@...oo.com>
> 
> The USB max packet size (always little-endian) was not being byte swapped on big-endian systems.
> Created with 2.6.32.16
> Applicable since [USB: ftdi_sio: fix hi-speed device packet size calculation] approx 2.6.31
> 
> Signed-off-by: Michael Wileczka <mikewileczka@...oo.com>
> ---
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1397,7 +1397,7 @@ static void ftdi_set_max_packet_size(str
>  	}
>  
>  	/* set max packet size based on descriptor */
> -	priv->max_packet_size = ep_desc->wMaxPacketSize;
> +	priv->max_packet_size = le16_to_cpu(ep_desc->wMaxPacketSize);
>  
>  	dev_info(&udev->dev, "Setting MaxPacketSize %d\n", priv->max_packet_size);
>  }

So I guess nobody noticed this because the driver deosn't get used on
big-endian machines a lot?

What are the user-visible effects of this bug?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/