[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100819144921.40d6765f.akpm@linux-foundation.org>
Date: Thu, 19 Aug 2010 14:49:21 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-kernel@...r.kernel.org,
Andy Shevchenko <ext-andriy.shevchenko@...ia.com>,
Adrian Hunter <adrian.hunter@...ia.com>,
linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: make dev_to_mmc_card() macro public
On Wed, 18 Aug 2010 16:31:18 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> Conversion from struct device to struct mmc_card is used more than in one
> place. Due to this it's better to have public macro for such thing.
>
nit: generally, subsystem-specific identifiers should use their
subsystem's identifier as a prefix. So a better name for
dev_to_mmc_card() would be mmc_dev_to_card().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists