lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Aug 2010 17:58:03 -0400 From: Don Zickus <dzickus@...hat.com> To: Peter Zijlstra <peterz@...radead.org> Cc: Robert Richter <robert.richter@....com>, Cyrill Gorcunov <gorcunov@...il.com>, Lin Ming <ming.m.lin@...el.com>, Ingo Molnar <mingo@...e.hu>, "fweisbec@...il.com" <fweisbec@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Huang, Ying" <ying.huang@...el.com>, Yinghai Lu <yinghai@...nel.org>, Andi Kleen <andi@...stfloor.org> Subject: Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs On Thu, Aug 19, 2010 at 04:27:13PM +0200, Peter Zijlstra wrote: > x86_pmu.drain_pebs(regs); > + } > > for_each_set_bit(bit, (unsigned long *)&status, X86_PMC_IDX_MAX) { > struct perf_event *event = cpuc->events[bit]; > > + handled++; > + > if (!test_bit(bit, cpuc->active_mask)) > continue; Sorry I didn't notice this earlier, but I think you want that handled++ after the if(..) continue pieces. Otherwise you will always have a number >1. :-) Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists