linux-kernel - Re: [PATCH] timer: initialize the field slack of timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100819165522.7e608703.akpm@linux-foundation.org>
Date:	Thu, 19 Aug 2010 16:55:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] timer: initialize the field slack of timer_list

On Tue, 17 Aug 2010 14:37:44 +0800
Changli Gao <xiaosuo@...il.com> wrote:

> TIMER_INITIALIZER() should initialize the field slack of timer_list as
> __init_timer() does.
> 

So it should.

> ---
>  include/linux/timer.h |    1 +
>  1 file changed, 1 insertion(+)
> diff --git a/include/linux/timer.h b/include/linux/timer.h
> index 38cf093..81de484 100644
> --- a/include/linux/timer.h
> +++ b/include/linux/timer.h
> @@ -54,6 +54,7 @@ extern struct tvec_base boot_tvec_bases;
>  		.expires = (_expires),				\
>  		.data = (_data),				\
>  		.base = &boot_tvec_bases,			\
> +		.slack = -1,					\
>  		__TIMER_LOCKDEP_MAP_INITIALIZER(		\
>  			__FILE__ ":" __stringify(__LINE__))	\
>  	}

I wonder what the runtime effects of this change are.  Methinks we were
wasting a few cycles in apply_slack()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/