linux-kernel - Re: [PATCH] firmware_class: fix typo in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100819052655.GD5832@core.coreip.homeip.net>
Date:	Wed, 18 Aug 2010 22:26:56 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	"Guy, Wey-Yi W" <wey-yi.w.guy@...el.com>
Subject: Re: [PATCH] firmware_class: fix typo in error path

On Wed, Aug 18, 2010 at 08:43:30AM -0700, Greg KH wrote:
> On Wed, Aug 18, 2010 at 05:15:18PM +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@...el.com>
> > 
> > In the error path, _request_firmware sets
> > firmware_p to NULL rather than *firmware_p,
> > which leads to passing a freed firmware
> > struct to drivers when the firmware file
> > cannot be found. Fix this.
> > 
> > Broken by commit f8a4bd3456b988fc73b2c.
> 
> Nice catch, thanks.  I'll queue it up.
> 

Yep, looks good, thank you for fixing this,

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/