linux-kernel - Re: Conversion of LIO-Target to use include/scsi/iscsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100820163058P.fujita.tomonori@lab.ntt.co.jp>
Date:	Fri, 20 Aug 2010 16:32:37 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	nab@...ux-iscsi.org
Cc:	michaelc@...wisc.edu, fujita.tomonori@....ntt.co.jp,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	hch@....de, James.Bottomley@...e.de, hare@...e.de
Subject: Re: Conversion of LIO-Target to use include/scsi/iscsi_proto.h defs

On Thu, 19 Aug 2010 15:45:47 -0700
"Nicholas A. Bellinger" <nab@...ux-iscsi.org> wrote:

> So, assuming that the conversion of all struct iscsi_init_* and struct
> iscsi_target* to use include/scsi/iscsi_proto.h defs just involves
> checking structure size and renaming the member use in
> drivers/target/lio-target, would it be acceptable to do something like:
> 
> /* iSCSI PDU Header */
> struct iscsi_cmd {
>         uint8_t opcode;
>         uint8_t flags;
>         __be16 rsvd2;
>         uint8_t hlength;
>         uint8_t dlength[3];
>         uint8_t lun[8];
>         itt_t    itt;   /* Initiator Task Tag */
>         __be32 data_length;
>         __be32 cmdsn;
>         __be32 exp_statsn;
>         uint8_t cdb[ISCSI_CDB_SIZE];    /* SCSI Command Block */
>         /* Additional Data (Command Dependent) */
> #ifdef ISCSI_TARGET_MODE
>         __be32 header_digest;
> #endif
> };

It's up to Mike but it looks hacky to me. struct iscsi_pdu is defined
in the exact way as the spec does.

I don't think that iscsi_proto.h conversion is a must for the mainline
inclusion. I prefer to let it alone for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/