linux-kernel - Re: [PATCHv2 2/2] omap: rx51: add support for USB chargers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282293711.1925.32.camel@chotu>
Date:	Fri, 20 Aug 2010 11:41:51 +0300
From:	Ameya Palande <ameya.palande@...ia.com>
To:	"Krogerus Heikki (EXT-Teleca/Helsinki)" 
	<ext-heikki.krogerus@...ia.com>
Cc:	ext Anton Vorontsov <cbouatmailru@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"Balbi Felipe (Nokia-MS/Helsinki)" <felipe.balbi@...ia.com>,
	"Lehtonen Markus (Nokia-MS/Helsinki)" <markus.lehtonen@...ia.com>,
	"Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@...ia.com>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCHv2 2/2] omap: rx51: add support for USB chargers

Hi Heikki,

On Thu, 2010-08-19 at 15:09 +0200, Krogerus Heikki (EXT-Teleca/Helsinki)
wrote:
> On Thu, Aug 19, 2010 at 02:40:42PM +0200, ext Anton Vorontsov wrote:
> > On Thu, Aug 19, 2010 at 03:09:37PM +0300, Krogerus Heikki (EXT-Teleca/Helsinki) wrote:
> >> @@ -909,5 +913,6 @@ void __init rx51_peripherals_init(void)
> >>  	spi_register_board_info(rx51_peripherals_spi_board_info,
> >>  				ARRAY_SIZE(rx51_peripherals_spi_board_info));
> >>  	omap2_hsmmc_init(mmc);
> >> +	platform_device_register(&rx51_charger_device);
> > 
> > Maybe
> > 
> >   platform_device_register_simple("isp1704_charger", -1, NULL, 0);
> 
> I guess it's enough in this case. Ameya, Roger, any objections?

Yes, I would have preferred "platform_device_register_simple" instead of
"platform_device_register", but doesn't matter now ;)

Cheers,
Ameya.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/