linux-kernel - [tip:x86/urgent] x86, apic: Fix apic=debug boot crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-05e407603e527f9d808dd3866d3a17c2ce4dfcc5@git.kernel.org>
Date:	Fri, 20 Aug 2010 12:41:24 GMT
From:	tip-bot for Daniel Kiper <dkiper@...-space.pl>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	dkiper@...-space.pl, tglx@...utronix.de, mingo@...e.hu
Subject: [tip:x86/urgent] x86, apic: Fix apic=debug boot crash

Commit-ID:  05e407603e527f9d808dd3866d3a17c2ce4dfcc5
Gitweb:     http://git.kernel.org/tip/05e407603e527f9d808dd3866d3a17c2ce4dfcc5
Author:     Daniel Kiper <dkiper@...-space.pl>
AuthorDate: Fri, 20 Aug 2010 00:46:16 +0200
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 20 Aug 2010 10:18:28 +0200

x86, apic: Fix apic=debug boot crash

Fix a boot crash when apic=debug is used and the APIC is
not properly initialized.

This issue appears during Xen Dom0 kernel boot but the
fix is generic and the crash could occur on real hardware
as well.

Signed-off-by: Daniel Kiper <dkiper@...-space.pl>
Cc: xen-devel@...ts.xensource.com
Cc: konrad.wilk@...cle.com
Cc: jeremy@...p.org
Cc: <stable@...nel.org> # .35.x, .34.x, .33.x, .32.x
LKML-Reference: <20100819224616.GB9967@...ter-fw-old.local.net-space.pl>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/apic/io_apic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 4dc0084..f1efeba 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1728,6 +1728,8 @@ __apicdebuginit(void) print_IO_APIC(void)
 		struct irq_pin_list *entry;
 
 		cfg = desc->chip_data;
+		if (!cfg)
+			continue;
 		entry = cfg->irq_2_pin;
 		if (!entry)
 			continue;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/