lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Aug 2010 09:13:36 -0400 From: Eric Paris <eparis@...hat.com> To: Andreas Schwab <schwab@...ux-m68k.org> Cc: Tvrtko Ursulin <tvrtko.ursulin@...hos.com>, Andreas Gruenbacher <agruen@...e.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: struct fanotify_event_metadata On Fri, 2010-08-20 at 11:16 +0200, Andreas Schwab wrote: > Tvrtko Ursulin <tvrtko.ursulin@...hos.com> writes: > > > Shrink pid field in the fanotify_event_metadata to 32-bit to match > > the kernel representation. Pull mask field up since it logically > > comes before event auxiliary data and also makes for a nicer > > alignment. > > That won't buy you much wrt. alignment though, due to the packed > attribute. Can you help me understand the packed attribute and why it hurts in this case? It's not going to change the alignment or placement of anything and I saw it as just being needed to make sure everything would continue to work in the future. I'm going to compile a couple of test programs (I only have x86 and x86_64) to see if I can find what the assembly is doing different but maybe you can point me at the information more easily? -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists