linux-kernel - Re: [PATCH] backlight: 88pm860x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100820112701.3f722b81.randy.dunlap@oracle.com>
Date:	Fri, 20 Aug 2010 11:27:01 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Henrik Kretzschmar <henne@...htwindheim.de>
Cc:	rpurdie@...ys.net, sameo@...ux.intel.com, mjg@...hat.com,
	error27@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: 88pm860x_bl: fix build failure

On Fri, 20 Aug 2010 20:01:55 +0200 Henrik Kretzschmar wrote:

> On x86_64 system this driver fails to build, since theres already a

fails as in an error, not just a warning?

I see this:

drivers/video/backlight/88pm860x_bl.c:24:1: warning: "CURRENT_MASK" redefined
arch/x86/include/asm/page_64_types.h:6:1: warning: this is the location of the previous definition


> macro called CURRENT_MASK in arch/asm/include/page_64_types.h
> So I renamed this macro to BL_CURRENT_MASK to aviod a collision.
> 
> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
> ---
> This patch is against Linux tree and tested.
> 
>  drivers/video/backlight/88pm860x_bl.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c
> index 38ffc3f..68bd602 100644
> --- a/drivers/video/backlight/88pm860x_bl.c
> +++ b/drivers/video/backlight/88pm860x_bl.c
> @@ -21,7 +21,7 @@
>  #define MAX_BRIGHTNESS		(0xFF)
>  #define MIN_BRIGHTNESS		(0)
>  
> -#define CURRENT_MASK		(0x1F << 1)
> +#define BL_CURRENT_MASK		(0x1F << 1)
>  
>  struct pm860x_backlight_data {
>  	struct pm860x_chip *chip;
> @@ -85,7 +85,7 @@ static int pm860x_backlight_set(struct backlight_device *bl, int brightness)
>  	if ((data->current_brightness == 0) && brightness) {
>  		if (data->iset) {
>  			ret = pm860x_set_bits(data->i2c, wled_idc(data->port),
> -					      CURRENT_MASK, data->iset);
> +					      BL_CURRENT_MASK, data->iset);
>  			if (ret < 0)
>  				goto out;
>  		}
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/