linux-kernel - Re: [PATCH] MFD: LP3974 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100820220950.GL3650@sortiz-mobl>
Date:	Sat, 21 Aug 2010 00:09:51 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Kyungmin Park <kmpark@...radead.org>
Cc:	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	broonie@...nsource.wolfsonmicro.com, jy0922.shim@...sung.com
Subject: Re: [PATCH] MFD: LP3974 PMIC support

Hi Kyungmin,

On Thu, Aug 19, 2010 at 02:08:39PM +0900, Kyungmin Park wrote:
> Any comments? I hope it's included the 2.6.36 if possible.
It hopefully will be. I received the patch after the merge window opened
though.
Some comments on your patch:

> > +config MFD_LP3974
> > +       bool "National Semiconductor LP3974 PMIC Support"
> > +       depends on I2C=y
> > +       select MFD_CORE
> > +       select MFD_MAX8998
> > +       help
> > +         Say yes here to support for National Semiconductor LP3974. This is
> > +         a Power Management IC. This driver provies common support for
> > +         accessing the device, additional drivers must be enabled in order
> > +         to use the functionality of the device.
> > +         Note that it has same functionality with max8998.
As Jonathan mentioned, there really is no need for a Kconfig symbol. Just
change the existing Kconfig comments to add your device there.


> >  config MFD_WM8400
> >        tristate "Support Wolfson Microelectronics WM8400"
> >        select MFD_CORE
> > diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> > index 0d68de2..cea9f48 100644
> > --- a/drivers/mfd/max8998.c
> > +++ b/drivers/mfd/max8998.c
> > @@ -30,6 +30,11 @@
> >  #include <linux/mfd/max8998.h>
> >  #include <linux/mfd/max8998-private.h>
> >
> > +enum max8998_type {
> > +       TYPE_MAX8998,
> > +       TYPE_LP3974,
> > +};
Not used, so please remove that.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/