linux-kernel - Re: [PATCH] perf tools: Fix linking errors with --as-needed flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100821172433.GF2973@ghostprotocols.net>
Date:	Sat, 21 Aug 2010 14:24:33 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Ozan Çağlayan <ozan@...dus.org.tr>
Cc:	"Kirill A. Shutemov" <kirill@...temov.name>,
	Tom Zanussi <tzanussi@...il.com>, linux-kernel@...r.kernel.org,
	mingo@...e.hu
Subject: Re: [PATCH] perf tools: Fix linking errors with --as-needed flag

Em Sun, Jul 18, 2010 at 02:04:32PM +0300, Ozan Çağlayan escreveu:
> On 18.07.2010 13:45, Ozan Çağlayan wrote:
> > External shared libraries should never be appended to the LDFLAGS as
> > this messes the linking order. As EXTLIBS collects those libraries,
> > it seems that perl and python libraries  should also be appended
> > to EXTLIBS.
> > 
> > Also fix the broken linking order.
> 
> Hm actually the PERL_EMBED_LDOPTS may contain LDFLAGS and LIBADD according
> to distribution's perl package configuration's goodness/badness. On my system
> the return value is crap which bloats the linking process:
> 
>  -rdynamic -Wl,-rpath,/usr/lib/perl5/5.10.1/i686-linux-thread-multi/CORE  -fstack-protector -L/usr/local/lib  -L/usr/lib/perl5/5.10.1/i686-linux-thread-multi/CORE -lperl -lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
> 
> PYTHON_EMBED_LDOPTS evaluates python-config --ldflags and adds these to 
> ALL_LDFLAGS. (--libs and --ldflags are synonyms for python-config). According
> to python-config this code *never* returns LDFLAGS so it's safe to put them in
> EXTLIBS.
> 
> So the cure may be more than this patch for perl stuff, but at least it fixes my
> linking problems with -Wl, --as-needed.

Can you refresh this patch? I had it in the back of my mind, remembered
it when considering a similar patch by Kirill, but his covers just the
python case.

Tom, can you please check Ozan's and Kirill's patches and tell me if I
can stick your Acked-by to them?

I'll CC you on the Kirill patch on private cover.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/