linux-kernel - Re: [PATCH,TRIVIAL] Replace Configure with Enable in description of MAXSMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=Pha8jRFhr+kQfh9doKZDW-=VHq2KqNxXaq6ts@mail.gmail.com>
Date:	Sat, 21 Aug 2010 12:45:12 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, Nick Piggin <npiggin@...nel.dk>
Subject: Re: [PATCH,TRIVIAL] Replace Configure with Enable in description of MAXSMP

On Sat, Aug 21, 2010 at 12:32 PM, Samuel Thibault
<samuel.thibault@...-lyon.org> wrote:
>
> Replace Configure with Enable in description of MAXSMP
>
> The "Configure" word tends to make user believe they have to say 'yes'
> to be able to choose the number of procs/nodes.  "Enable" should be
> unambiguous enough.

What broken patch-generation tools do you use, btw? Nick Piggin has
the same problem: the Subject of the patch gets repeated as the first
line of the body of the thing, which is very annoying. Either I have
to go in and edit the email (which I try to do), or the thing gets
repeated in the commit message.

Yes, the summary line is interesting, but it's _not_ interesting
enough that people want to see it twice.

(See commit 99b7db7b8ffd for an example of where it got repeated twice
- Al Viro isn't as anal as me about commit messages, and clearly
didn't edit the email before applying it).

If you want to repeat the summary line, please repeat the "Subject:"
part of the line too, so that the tools automatically see that it's
just a repeat of the Subject: line. Same goes if you want to add
author information: make sure that the author information has that
"From: " prepended to it.

And if it really is a tool that creates these buggy patch messages
with duplicate summary information, please let's just fix that buggy
crud.

I edited this by hand, but it annoys me when I have to do mindless
silly stuff just because people submit broken patch descriptions.

                                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/