linux-kernel - Re: [spi-devel-general] [PATCH 2/2] spi/spi_s3c64xx: Staticise non-exported functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Aug 2010 10:52:44 +0900
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Grant Likely <grant.likely@...retlab.ca>,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [spi-devel-general] [PATCH 2/2] spi/spi_s3c64xx: Staticise
 non-exported functions

On Sat, Aug 21, 2010 at 1:17 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/spi/spi_s3c64xx.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
> index a0b63b7..7e627f7 100644
> --- a/drivers/spi/spi_s3c64xx.c
> +++ b/drivers/spi/spi_s3c64xx.c
> @@ -447,8 +447,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
>        writel(val, regs + S3C64XX_SPI_CLK_CFG);
>  }
>
> -void s3c64xx_spi_dma_rxcb(struct s3c2410_dma_chan *chan, void *buf_id,
> -                               int size, enum s3c2410_dma_buffresult res)
> +static void s3c64xx_spi_dma_rxcb(struct s3c2410_dma_chan *chan, void *buf_id,
> +                                int size, enum s3c2410_dma_buffresult res)
>  {
>        struct s3c64xx_spi_driver_data *sdd = buf_id;
>        unsigned long flags;
> @@ -467,8 +467,8 @@ void s3c64xx_spi_dma_rxcb(struct s3c2410_dma_chan *chan, void *buf_id,
>        spin_unlock_irqrestore(&sdd->lock, flags);
>  }
>
> -void s3c64xx_spi_dma_txcb(struct s3c2410_dma_chan *chan, void *buf_id,
> -                               int size, enum s3c2410_dma_buffresult res)
> +static void s3c64xx_spi_dma_txcb(struct s3c2410_dma_chan *chan, void *buf_id,
> +                                int size, enum s3c2410_dma_buffresult res)
>  {
>        struct s3c64xx_spi_driver_data *sdd = buf_id;
>        unsigned long flags;

Oh, yes. What was I thinking ?!

Acked-by: Jassi Brar <jassisinghbrar@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/