linux-kernel - Re: [PATCH][RESEND] fix compilation error with CROSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100821072454.GA25054@merkur.ravnborg.org>
Date:	Sat, 21 Aug 2010 09:24:54 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Tiago Maluta <tiago.maluta@...il.com>,
	Michal Marek <mmarek@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RESEND] fix compilation error with CROSS_COMPILE

On Sat, Aug 21, 2010 at 02:21:33PM +0800, Wu Fengguang wrote:
>         $ make CROSS_COMPILE=x86_64-linux-gnu-
>         ...
>         cc1: error: unrecognized command line option "-m64"
>         cc1: error: unrecognized command line option "-mno-red-zone"
>         cc1: error: unrecognized command line option "-mcmodel=kernel"
>         cc1: error: unrecognized command line option "-maccumulate-outgoing-args"
> 
> Cc: Tiago Maluta <tiago.maluta@...il.com>
> Cc: Michal Marek <mmarek@...e.cz>
> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> ---
> 
> Andrew: the compile error only occurs in the -mm tree
> The bug is introduced by patch "Linux has an recent option to define
> CROSS_COMPILE in menuconfig.".
> 
> diff --git a/Makefile b/Makefile
> index d646d69..af8864e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -190,7 +190,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
>  export KBUILD_BUILDHOST := $(SUBARCH)
>  ARCH		?= $(SUBARCH)
>  CROSS_COMPILE	?=
> -CROSS_COMPILE	:= $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)
> +CROSS_COMPILE	?= $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)

I cannot see how this would solve your problem.
Any variable assigned using := or ?= can be overrided by  variable
assigned on the command line like this:

   make VAR=values

Please note that there is a big difference between the above and this:

    VAR=value make

In the latter case you pass in VAR using the enviroment and it
is just like any other environment variable as seen from make.

On top of that the upstream kernel does not have the first
assignmnet to CROSS_COMPILE - so you need to update
your sources (or Andrews --mm is not recent enough.

Please try again with upstream kernel and let us know what you
conclude.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/