linux-kernel - Re: [PATCH -V18 04/13] vfs: Allow handle based open on symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m339u8s44h.fsf@linux.vnet.ibm.com>
Date:	Sat, 21 Aug 2010 15:02:14 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Andreas Dilger <andreas.dilger@...cle.com>,
	Neil Brown <neilb@...e.de>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	"adilger\@sun.com" <adilger@....com>,
	"corbet\@lwn.net" <corbet@....net>,
	"npiggin\@kernel.dk" <npiggin@...nel.dk>,
	"hooanon05\@yahoo.co.jp" <hooanon05@...oo.co.jp>,
	"bfields\@fieldses.org" <bfields@...ldses.org>,
	"miklos\@szeredi.hu" <miklos@...redi.hu>,
	"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"sfrench\@us.ibm.com" <sfrench@...ibm.com>,
	"philippe.deniel\@CEA.FR" <philippe.deniel@....FR>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -V18 04/13] vfs: Allow handle based open on symlinks

On Sat, 21 Aug 2010 01:13:52 -0600, Andreas Dilger <andreas.dilger@...cle.com> wrote:
> On 2010-08-20, at 18:09, Neil Brown <neilb@...e.de> wrote:
> > How about a new AT flag:  AT_FILE_HANDLE
> > 
> > Meaning is that the 'dirfd' is used only to identify a filesystem (vfsmnt) and
> > the 'name' pointer actually points to a filehandle fragment interpreted in
> > that filesystem.
> > 
> > One problem is that there is no way to pass the length...
> > Options:
> >   fragment is at most 64 bytes nul padded at the end
> >   fragment is hex encoded and nul terminated
> >   ??
> > 
> > I think I prefer the hex encoding, but I'm hoping someone else has a better
> > idea.
> 
> That makes it ugly for the kernel to stringify and parse the file handles. 
> 
> How about for AT_FILE_HANDLE THE FIRST __u32 (maybe with an extra
> __u32 for alignment) is the length and the rest of the binary file
> handle follows this?  In fact, doesn't the handle itself already
> encode the length in the header?


struct file_handle already include length

-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/