linux-kernel - Re: [PATCH] USB: Fix kernel oops with g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C6FD450.6040405@ru.mvista.com>
Date:	Sat, 21 Aug 2010 17:27:44 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Maxim Osipov <maxim.osipov@...il.com>
CC:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: Fix kernel oops with g_ether and Windows

Hello.

Maxim Osipov wrote:

> Please find attached patch for
> https://bugzilla.kernel.org/show_bug.cgi?id=16023 problem.

    It's preferrable that the patahces areposted inline.

> Kind regards,
> Maxim

> From 43568dec4f387da4562d5bc81557c642a468b685 Mon Sep 17 00:00:00 2001
> From: Maxim Osipov <maxim.osipov@...il.com>
> Date: Thu, 19 Aug 2010 07:25:28 +0400
> Subject: [PATCH] USB: Fix kernel oops with g_ether and Windows

> Signed-off-by: Maxim Osipov <maxim.osipov@...il.com>
[...]
> diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c
> index 5c0d06c..1043da1 100644
> --- a/drivers/usb/gadget/rndis.c
> +++ b/drivers/usb/gadget/rndis.c
> @@ -292,9 +292,13 @@ gen_ndis_query_resp (int configNr, u32 OID, u8 *buf, unsigned buf_len,
>  	/* mandatory */
>  	case OID_GEN_VENDOR_DESCRIPTION:
>  		pr_debug("%s: OID_GEN_VENDOR_DESCRIPTION\n", __func__);
> -		length = strlen (rndis_per_dev_params [configNr].vendorDescr);
> -		memcpy (outbuf,
> -			rndis_per_dev_params [configNr].vendorDescr, length);
> +		if ( rndis_per_dev_params [configNr].vendorDescr ) {

    There should be not space after ( and before ). Run your patches thru 
scripts/checkpatch.pl before submitting please.

> +			length = strlen (rndis_per_dev_params [configNr].vendorDescr);
> +			memcpy (outbuf,
> +				rndis_per_dev_params [configNr].vendorDescr, length);

    Should be no space before ( either and before [ too.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/