lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Aug 2010 06:50:12 -0700 (PDT) From: Alex Dubov <oakad@...oo.com> To: Maxim Levitsky <maximlevitsky@...il.com> Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH] My work on MemoryStick system > > I just tested this series with Jmicron, and unfortunelly > there are bugs. > > * driver refuses to handle 26 byte TPC I use to read regs > (sizeof(ms_registers). If I bump it to 32, it works. It will work with any multiply of 4 (24 and 28 work as well). It's a known "feature". > > * With this fix first few reads still fail. > That means that card isn't detected always because boot > blocks might not > be read. > Later card works fine. > > * Also I found out that msproblk.c allocates memory for > attributes IO > using stock kmalloc, and hangs that to driver. > However if driver doesn't support such address, it will > fail. Why would hardware do anything at all with attribute memory space? > I fixed that in my driver by properly calling dma_unmap_sg, > and thus > using SWIOTLB if necessary. > But Jmicron driver doesn't unmap its sg. > (Yet the system with Jmicron device has just one GB, so > this isn't the > problem I am seeing). > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists