| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Aug 2010 15:07:41 +0200 From: Arnd Bergmann <arnd@...db.de> To: Changli Gao <xiaosuo@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <eric.dumazet@...il.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] net: define __packed for the userspace code On Sunday 22 August 2010 13:23:42 Changli Gao wrote: > On Sun, Aug 22, 2010 at 7:12 PM, Changli Gao <xiaosuo@...il.com> wrote: > > This commit > > > > commit bc10502dba37d3b210efd9f3867212298f13b78e > > Author: Eric Dumazet <eric.dumazet@...il.com> > > Date: Thu Jun 3 03:21:52 2010 -0700 > > > > net: use __packed annotation > > > > makes use of __packed in the userspace code. So we'd better define __packed > > for the userspace code too. > > > > Oh, sorry. This patch can't work as include/linux/compiler.h isn't > exported to the userspace. But where should we define __packed for the > userspace code? include/linux/types.h? I would try to avoid making those structures packed to start with. >From what I can see, they structures annotated in the above commit mostly don't even require explicit packing because they are already packed. Not marking them packed makes the code portable to non-gcc compilers. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists