linux-kernel - Re: [PATCH] blk-fs: put dev->kobj in blk_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C724DFB.2060707@kernel.dk>
Date:	Mon, 23 Aug 2010 12:31:23 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Xiaotian Feng <dfeng@...hat.com>
CC:	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	Nikanth Karthikesan <knikanth@...e.de>,
	David Teigland <teigland@...hat.com>
Subject: Re: [PATCH] blk-fs: put dev->kobj in blk_register_queue fail path

On 2010-08-13 12:44, Xiaotian Feng wrote:
> kernel needs to kobject_put on dev->kobj if elv_register_queue fails.
> 
> Signed-off-by: Xiaotian Feng <dfeng@...hat.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: Stephen Hemminger <shemminger@...tta.com>
> Cc: Nikanth Karthikesan <knikanth@...e.de>
> Cc: David Teigland <teigland@...hat.com>
> ---
>  block/blk-sysfs.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index 001ab18..0749b89 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -511,6 +511,7 @@ int blk_register_queue(struct gendisk *disk)
>  		kobject_uevent(&q->kobj, KOBJ_REMOVE);
>  		kobject_del(&q->kobj);
>  		blk_trace_remove_sysfs(disk_to_dev(disk));
> +		kobject_put(&dev->kobj);
>  		return ret;
>  	}
>  

Looks correct. Thanks, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/