linux-kernel - Re: [patch] i915: remove unneed NULL checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100823112828.GK6674@bicker>
Date:	Mon, 23 Aug 2010 13:28:28 +0200
From:	Dan Carpenter <error27@...il.com>
To:	David Airlie <airlied@...ux.ie>
Cc:	Eric Anholt <eric@...olt.net>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Zhenyu Wang <zhenyuw@...ux.intel.com>,
	Zhao Yakui <yakui.zhao@...el.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] i915: remove unneed NULL checks

On Wed, Jun 23, 2010 at 07:06:22PM +0200, Dan Carpenter wrote:
> We don't need to check the list cursor in a list_for_each_entry().  It's
> always non-null.
> 

Here is another one that never got applied.  I has a sad face.  :(

regards,
dan carpenter

> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index cc8131f..8a2bdfc 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -745,7 +745,7 @@ bool intel_pipe_has_type (struct drm_crtc *crtc, int type)
>      struct drm_encoder *l_entry;
>  
>      list_for_each_entry(l_entry, &mode_config->encoder_list, head) {
> -	    if (l_entry && l_entry->crtc == crtc) {
> +	    if (l_entry->crtc == crtc) {
>  		    struct intel_encoder *intel_encoder = enc_to_intel_encoder(l_entry);
>  		    if (intel_encoder->type == type)
>  			    return true;
> @@ -3322,7 +3322,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
>  
>  	list_for_each_entry(encoder, &mode_config->encoder_list, head) {
>  
> -		if (!encoder || encoder->crtc != crtc)
> +		if (encoder->crtc != crtc)
>  			continue;
>  
>  		intel_encoder = enc_to_intel_encoder(encoder);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/