linux-kernel - Re: [PATCHSET block#for-2.6.36-post] block: replace barrier with sequenced flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100823141935.GA23963@lst.de>
Date:	Mon, 23 Aug 2010 16:19:35 +0200
From:	Christoph Hellwig <hch@....de>
To:	Tejun Heo <tj@...nel.org>
Cc:	Christoph Hellwig <hch@....de>, Jens Axboe <jaxboe@...ionio.com>,
	Ric Wheeler <rwheeler@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	"James.Bottomley@...e.de" <James.Bottomley@...e.de>,
	"tytso@....edu" <tytso@....edu>,
	"chris.mason@...cle.com" <chris.mason@...cle.com>,
	"swhiteho@...hat.com" <swhiteho@...hat.com>,
	"konishi.ryusuke@....ntt.co.jp" <konishi.ryusuke@....ntt.co.jp>,
	"dm-devel@...hat.com" <dm-devel@...hat.com>,
	"vst@...b.net" <vst@...b.net>, "jack@...e.cz" <jack@...e.cz>,
	"hare@...e.de" <hare@...e.de>
Subject: Re: [PATCHSET block#for-2.6.36-post] block: replace barrier with sequenced flush

On Mon, Aug 23, 2010 at 04:13:36PM +0200, Tejun Heo wrote:
> Yeah, that sounds reasonable.  blk_queue_flush() can be called anytime
> without locking anyway, so it should be really easy to implement too.

I don't think we can simply call blk_queue_flush - we must ensure to
never set more bits than the device allows.  We'll just need two
sets of flags in the request queue, with the sysfs file checking that
it never allows more flags than blk_queue_flush.

I'll prepare a patch for this on top of the current series.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/