linux-kernel - Re: [PATCH] net: define __packed for the userspace code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100822.193609.35028164.davem@davemloft.net>
Date:	Sun, 22 Aug 2010 19:36:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	arnd@...db.de, eric.dumazet@...il.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: define __packed for the userspace code

From: Changli Gao <xiaosuo@...il.com>
Date: Mon, 23 Aug 2010 10:29:49 +0800

> Do you mean that use the __attribute__((packed)) annotation in all of
> these files:
> 
> localhost linux # grep "\<__packed\>" usr/include/ -r | uniq
> usr/include/linux/if_hippi.h:} __packed;
> usr/include/linux/if_fddi.h:} __packed;
> usr/include/linux/nbd.h:} __packed;
> usr/include/linux/ncp.h:} __packed;
> usr/include/linux/rfkill.h:} __packed;
> usr/include/linux/if_pppox.h:} __packed;
> usr/include/linux/phonet.h:} __packed;
> usr/include/linux/ipv6.h:} __packed;    /* required for some archs */
> usr/include/linux/ipv6.h:} __packed;
> usr/include/linux/if_ether.h:} __packed;

It seems so, yes.

There is no way that anybody has tried to compile anything in
userspace using these headers with the __packed usage there.

If they would, they would surely see a compile failure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/