linux-kernel - Re: [PATCH v5 07/12] Maintain memslot version number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C729961.7070308@redhat.com>
Date:	Mon, 23 Aug 2010 18:53:05 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Gleb Natapov <gleb@...hat.com>
CC:	kvm@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de, hpa@...or.com,
	riel@...hat.com, cl@...ux-foundation.org, mtosatti@...hat.com
Subject: Re: [PATCH v5 07/12] Maintain memslot version number

  On 07/19/2010 06:30 PM, Gleb Natapov wrote:
> Code that depends on particular memslot layout can track changes and
> adjust to new layout.
>
>
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index c13cc48..c74ffc0 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -177,6 +177,7 @@ struct kvm {
>   	raw_spinlock_t requests_lock;
>   	struct mutex slots_lock;
>   	struct mm_struct *mm; /* userspace tied to this vm */
> +	u32 memslot_version;
>   	struct kvm_memslots *memslots;
>   	struct srcu_struct srcu;
>   #ifdef CONFIG_KVM_APIC_ARCHITECTURE
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index b78b794..292514c 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -733,6 +733,7 @@ skip_lpage:
>   	slots->memslots[mem->slot] = new;
>   	old_memslots = kvm->memslots;
>   	rcu_assign_pointer(kvm->memslots, slots);
> +	kvm->memslot_version++;
>   	synchronize_srcu_expedited(&kvm->srcu);
>
>   	kvm_arch_commit_memory_region(kvm, mem, old, user_alloc);

How does this interact with rcu?  Nothing enforces consistency between 
rcu_dereference(kvm->memslots) and kvm->memslot_version.

Should probably be rcu_dereference(kvm->memslots)->version.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/