linux-kernel - Re: [PATCH v5 03/12] Add async PF initialization to PV guest.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Aug 2010 19:10:45 +0300
From:	Gleb Natapov <gleb@...hat.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Avi Kivity <avi@...hat.com>, kvm@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de, hpa@...or.com,
	riel@...hat.com, mtosatti@...hat.com
Subject: Re: [PATCH v5 03/12] Add async PF initialization to PV guest.

On Mon, Aug 23, 2010 at 11:08:06AM -0500, Christoph Lameter wrote:
> On Mon, 23 Aug 2010, Gleb Natapov wrote:
> 
> > > The guest will have to align this on a 64 byte boundary, should this
> > > be marked __aligned(64) here?
> > >
> > I do __aligned(64) when I declare variable of that type:
> >
> > static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);
> 
> 64 byte boundary: You mean cacheline aligned? We have a special define for
> that.
> 
> DEFINE_PER_CPU_SHARED_ALIGNED
IIRC I tried to use it and it does different alignment on 64/32 bit. The
alignment here is part of guest/host interface so it should be the same
on both.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/