linux-kernel - Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1008231217100.9840@router.home>
Date:	Mon, 23 Aug 2010 12:17:31 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Minchan Kim <minchan.kim@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel List <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Hugh Dickins <hughd@...gle.com>,
	Andi Kleen <andi@...stfloor.org>, Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting

On Tue, 24 Aug 2010, Minchan Kim wrote:

> On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote:
> > On Tue, 24 Aug 2010, Minchan Kim wrote
> >
> > > This patch introude new argument 'cleanup' to migrate_pages.
> > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists.
> > > Otherwise, caller need to clean up the lists so it has a chance to postprocess
> > > the pages.
> >
> > Could we simply make migrate_pages simply not do any cleanup?
> > Caller has to call putback_lru_pages()?
> >
> Hmm. maybe I misunderstood your point.
> Your point is that let's make whole caller of migrate_pagse has a responsibility
> of clean up the list?

Yes. All callers would be responsible for cleanup.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/