linux-kernel - Re: [PATCH 0/4 v2] kvm: rework KVM mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTindpNLN+xeDPhuFWrktqZZafgQ+gK_F1sF5Gwh8@mail.gmail.com>
Date:	Mon, 23 Aug 2010 12:53:00 -0700
From:	Tim Pepper <lnxninja@...ux.vnet.ibm.com>
To:	Avi Kivity <avi@...hat.com>
Cc:	Xiaotian Feng <xtfeng@...il.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>, kvm@...r.kernel.org
Subject: Re: [PATCH 0/4 v2] kvm: rework KVM mmu_shrink() code

On Mon, Aug 23, 2010 at 4:28 AM, Avi Kivity <avi@...hat.com> wrote:
>  On 08/23/2010 02:11 PM, Xiaotian Feng wrote:
>>
>> On Mon, Aug 23, 2010 at 6:27 PM, Avi Kivity<avi@...hat.com>  wrote:
>>>
>>>  On 08/23/2010 01:22 PM, Avi Kivity wrote:
>>>>
>>>> I see a lot of soft lockups with this patchset:
>>>
>>> This is running the emulator.flat test case, with shadow paging.  This
>>> test
>>> triggers a lot (millions) of mmu mode switches.
>>>
>> Does following patch fix your issue?
>>
>
> It does indeed!

Thanks Xiaotian Feng!

Avi: here's also a minor whitespace fixup on top of the previous.

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
         index f83b941..0c56484 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -1696,8 +1696,7 @@ void kvm_mmu_change_mmu_pages(struct kvm *kvm,
unsigned in
                        page = container_of(kvm->arch.active_mmu_pages.prev,
                                            struct kvm_mmu_page, link);
-                       kvm_mmu_prepare_zap_page(kvm, page,
-                                                              &invalid_list);
+                       kvm_mmu_prepare_zap_page(kvm, page, &invalid_list);
                        kvm_mmu_commit_zap_page(kvm, &invalid_list);
                }
                goal_nr_mmu_pages = kvm->arch.n_used_mmu_pages;



Tim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/