linux-kernel - Re: [PATCH] tty: Remove __GFP_NOFAIL from tty_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1008231405260.20535@chino.kir.corp.google.com>
Date:	Mon, 23 Aug 2010 14:06:58 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Pekka Enberg <penberg@...nel.org>
cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] tty: Remove __GFP_NOFAIL from tty_add_file()

On Mon, 23 Aug 2010, Pekka Enberg wrote:

> diff --git a/drivers/char/pty.c b/drivers/char/pty.c
> index c350d01..bc577ac 100644
> --- a/drivers/char/pty.c
> +++ b/drivers/char/pty.c
> @@ -676,7 +676,9 @@ static int ptmx_open(struct inode *inode, struct file *filp)
>  
>  	set_bit(TTY_PTY_LOCK, &tty->flags); /* LOCK THE SLAVE */
>  
> -	tty_add_file(tty, filp);
> +	retval = tty_add_file(tty, filp);
> +	if (retval)
> +		goto out1;
>  
>  	retval = devpts_pty_new(inode, tty->link);
>  	if (retval)

This needs devpts_kill_index() to reverse the successful 
devpts_new_index(), so I think it should be "goto out" and not "goto 
out1".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/