linux-kernel - Re: [PATCH][resend] scripts/mod/modpost.c: fix commentary accordingly to last changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100823065233.GM5168@cr0.nay.redhat.com>
Date:	Mon, 23 Aug 2010 14:52:33 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH][resend] scripts/mod/modpost.c: fix commentary
 accordingly to last changes

On Tue, Aug 17, 2010 at 01:36:40PM +0300, Andy Shevchenko wrote:
>The last commits
> 37ed19d5cce35a40d3913cf9aa208ce9f60db3d7
> 5003bab82d56754b27be01eef24495a02e00039d
>have introduced new behaviour of sec2annotation() method. However, the
>commentary inside the method was left as before. Let's fix it accordingly.
>
>Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
>Cc: Rusty Russell <rusty@...tcorp.com.au>
>Cc: Andrew Morton <akpm@...ux-foundation.org>


Acked-by: WANG Cong <xiyou.wangcong@...il.com>

>---
> scripts/mod/modpost.c |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>index 1ec7158..33122ca 100644
>--- a/scripts/mod/modpost.c
>+++ b/scripts/mod/modpost.c
>@@ -1208,6 +1208,9 @@ static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr,
>  * .cpuinit.data => __cpudata
>  * .memexitconst => __memconst
>  * etc.
>+ *
>+ * The memory of returned value has been allocated on a heap. The user of this
>+ * method should free it after usage.
> */
> static char *sec2annotation(const char *s)
> {
>@@ -1230,7 +1233,7 @@ static char *sec2annotation(const char *s)
> 			strcat(p, "data ");
> 		else
> 			strcat(p, " ");
>-		return r; /* we leak her but we do not care */
>+		return r;
> 	} else {
> 		return strdup("");
> 	}
>-- 
>1.6.3.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/