linux-kernel - Re: [PATCH] Ramoops: use the platform data structure instead of module params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimyC2PcTgEbeKNQTCobxEKj-+wMViEOhNfE6JTg@mail.gmail.com>
Date:	Mon, 23 Aug 2010 15:53:49 +0900
From:	Kyungmin Park <kmpark@...radead.org>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Ramoops: use the platform data structure instead of
 module params

On Mon, Aug 23, 2010 at 3:48 PM, Marco Stornelli
<marco.stornelli@...il.com> wrote:
> 2010/8/18 Kyungmin Park <kmpark@...radead.org>:
>> From: Kyungmin Park <kyungmin.park@...sung.com>
>>
>> As each board and system has different memory for ramoops. It's better to define the platform data instead of module params.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
>> ---
>
> It seems good. Currently there isn't any code that register a ramoops
> device, isn't it?

At this time

I wrote it below

static struct ramoops_platform_data goni_ramoops_data = {
        .mem_size               = SZ_16K,
        .mem_address            = 0xED000000,   /* MODEM SRAM */
};

static struct platform_device goni_ramoops = {
        .name = "ramoops",
        .dev = {
                .platform_data = &goni_ramoops_data,
        },
};

Thank you,
Kyungmin Park
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/