linux-kernel - Re: [PATCH 1/1] HPET: unmap unused I/O space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C7368E4.30501@ladisch.de>
Date:	Tue, 24 Aug 2010 08:38:28 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] HPET: unmap unused I/O space

Jiri Slaby wrote:
> When the initialization code in hpet founds a memory resource and does
> not found IRQ, it does not unmap the memory resource previously
> mapped.
> [...]
> Since I got no reply previously, fix this by simply unmapping the
> space when IRQ is not found and memory region was mapped previously.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Clemens Ladisch <clemens@...isch.de>

Acked-by: Clemens Ladisch <clemens@...isch.de>

> ---
>  drivers/char/hpet.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -1017,6 +1017,8 @@ static int hpet_acpi_add(struct acpi_device *device)
>  		return -ENODEV;
>  
>  	if (!data.hd_address || !data.hd_nirqs) {
> +		if (data.hd_address)
> +			iounmap(data.hd_address);
>  		printk("%s: no address or irqs in _CRS\n", __func__);
>  		return -ENODEV;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/