linux-kernel - [PATCH] perf: fix core dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=9Cn=R8SPMCRp5z+gEjXbaBHeb-AaOtRbuwwcn@mail.gmail.com>
Date:	Tue, 24 Aug 2010 15:07:33 +0800
From:	jovi zhang <bookjovi@...il.com>
To:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...e.hu,
	acme@...hat.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] perf: fix core dump

Perf invoke symbol__init function twice when we input command "perf
kmem/sched record ls", then it will core dump when symbol__exit
invoked.
So give a flag to make symbol__init can be invoked once.

Signed-off-by: Jovi Zhang <bookjovi@...il.com>
tools/perf/util/symbol.c |    9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 1a36773..aded121 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -43,6 +43,8 @@ struct symbol_conf symbol_conf = {
       .try_vmlinux_path = true,
};

+static bool symbol_initizated;
+
int dso__name_len(const struct dso *self)
{
       if (verbose)
@@ -2268,6 +2270,11 @@ static int setup_list(struct strlist **list,
const char *list_str,

int symbol__init(void)
{
+       if (symbol_initizated == true)
+               return 0;
+       else
+               symbol_initizated = true;
+
       elf_version(EV_CURRENT);
       if (symbol_conf.sort_by_name)
               symbol_conf.priv_size += (sizeof(struct symbol_name_rb_node) -
@@ -2304,6 +2311,8 @@ out_free_comm_list:

void symbol__exit(void)
{
+       if (symbol_initizated == false)
+               return;
       strlist__delete(symbol_conf.sym_list);
       strlist__delete(symbol_conf.dso_list);
       strlist__delete(symbol_conf.comm_list);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/