linux-kernel - Re: [PATCH] Add intel drm blacklist to intel_opregion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <4C74690E020000230001F3F1@novprvlin0050.provo.novell.com>
Date:	Tue, 24 Aug 2010 08:51:26 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<mjg59@...f.ucam.org>
Cc:	<gregkh@...e.de>, <trenn@...e.de>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <Dennis.Jansen@....de>
Subject: Re: [PATCH] Add intel drm blacklist to intel_opregion_present
 detect

Hi Matthew, 

於 二，2010-08-24 於 15:22 +0100，Matthew Garrett 提到：
> Erm. Sorry about that - I just realised that there's actually a fairly 
> significant problem with it :) Right now you'll perform the register 
> call unconditionally on module load. You need to make sure that there's 
> actually Poulsbo hardware in the system, either by registering as a 
> proper PCI driver and calling acpi_video_register in your probe function 
> (and unregister in your remove function) or walking the PCI device list 
> looking for a psb device.
> 

Sorry! You are right! That's my fail!
I will put the PCI device check in probe function then send patch again.

Appreciate for your review.


Thank's a lot!
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/