linux-kernel - Re: [PATCH 4/5] drivers/char/agp: Eliminate memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1008242146040.14009@ask.diku.dk>
Date:	Tue, 24 Aug 2010 21:46:23 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Dan Carpenter <error27@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/5] drivers/char/agp: Eliminate memory leak

On Tue, 24 Aug 2010, Dan Carpenter wrote:

> On Tue, Aug 24, 2010 at 04:39:29PM +0200, Julia Lawall wrote:
> >  
> > -	error = agp_add_bridge(bridge);
> > +	return agp_add_bridge(bridge);
> >  
> 
> 	error = agp_add_bridge(bridge);
> 	if (error)
> 		goto fail;
> 	return 0;

Good point.  I will send another patch.

julia

> >  fail:
> > +	kfree(fake_bridge_dev);
> >  	return error;
> >  }
> >  
> 
> regards,
> dan carpenter
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/