lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Aug 2010 13:47:45 +0800 From: Eric Miao <eric.y.miao@...il.com> To: Axel Lin <axel.lin@...il.com> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Samuel Ortiz <sameo@...ux.intel.com>, Mike Rapoport <mike@...pulab.co.il> Subject: Re: [PATCH 1/3] mfd: da903x - fix da903x_add_subdevs error path On Tue, Aug 24, 2010 at 1:44 PM, Axel Lin <axel.lin@...il.com> wrote: > This patch fixes da903x_add_subdevs error path: > 1. return -ENOMEM if platform_device_alloc() fail. > 2. call platform_device_put() if platform_device_add() fail. > > Signed-off-by: Axel Lin <axel.lin@...il.com> Acked-by: Eric Miao <eric.y.miao@...il.com> > --- > drivers/mfd/da903x.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c > index c07aece..2fadbae 100644 > --- a/drivers/mfd/da903x.c > +++ b/drivers/mfd/da903x.c > @@ -470,13 +470,19 @@ static int __devinit da903x_add_subdevs(struct da903x_chip *chip, > subdev = &pdata->subdevs[i]; > > pdev = platform_device_alloc(subdev->name, subdev->id); > + if (!pdev) { > + ret = -ENOMEM; > + goto failed; > + } > > pdev->dev.parent = chip->dev; > pdev->dev.platform_data = subdev->platform_data; > > ret = platform_device_add(pdev); > - if (ret) > + if (ret) { > + platform_device_put(pdev); > goto failed; > + } > } > return 0; > > -- > 1.7.2 > > > >
Powered by blists - more mailing lists