linux-kernel - Re: [PATCH] avoiding the same resource to be inserted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikaBiptt+nF3A0cCsy7dKTZN+nAKHFT=MkE_TrF@mail.gmail.com>
Date:	Wed, 25 Aug 2010 15:01:56 +0800
From:	Huang Shijie <shijie8@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Bjorn Helgaas <bjorn.helgaas@...com>
Subject: Re: [PATCH] avoiding the same resource to be inserted

On Wed, Aug 25, 2010 at 2:41 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Wed, 25 Aug 2010 13:03:55 +0800 Huang Shijie <shijie8@...il.com> wrote:
>
>> On Wed, Aug 25, 2010 at 7:46 AM, Andrew Morton
>> <akpm@...ux-foundation.org> wrote:
>>
>> I think WARN_ON() is not power enough. If the CONFIG_BUG is not
>> defined, the warning message may not be printed. So I think using a
>> directly printk() here is better.
>
> No, WARN_ON() is good.  It gives us a backtrace and identifies the
> buggy code.  Only maniacs turn off CONFIG_BUG.
>

got it. Thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/