linux-kernel - [PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1282740904-1244-2-git-send-email-monstr@monstr.eu>
Date:	Wed, 25 Aug 2010 14:55:04 +0200
From:	Michal Simek <monstr@...str.eu>
To:	linux-kernel@...r.kernel.org
Cc:	linux-serial@...r.kernel.org, gregkh@...e.de,
	Michal Simek <monstr@...str.eu>,
	Peter Korsgaard <jacmet@...site.dk>
Subject: [PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll_char

The previous patch
"serial: Add CONSOLE_POLL support for uartlite"
(sha1 id 52ea4a7ef12f286bd68d13a93daaa688f56a1e14)
contained obcure loop in ulite_get_poll_char function.

Signed-off-by: Michal Simek <monstr@...str.eu>
Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
---
 drivers/serial/uartlite.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
index c0fae0d..c4bf54b 100644
--- a/drivers/serial/uartlite.c
+++ b/drivers/serial/uartlite.c
@@ -325,7 +325,7 @@ static int ulite_verify_port(struct uart_port *port, struct serial_struct *ser)
 #ifdef CONFIG_CONSOLE_POLL
 static int ulite_get_poll_char(struct uart_port *port)
 {
-	while (!(ioread32be(port->membase + ULITE_STATUS)
+	if (!(ioread32be(port->membase + ULITE_STATUS)
 						& ULITE_STATUS_RXVALID))
 		return NO_POLL_CHAR;
 
-- 
1.5.5.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/