linux-kernel - Re: [PATCH] Add new linearfb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Aug 2010 13:24:01 -0400
From:	Peter Jones <pjones@...hat.com>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
CC:	Colin Watson <cjwatson@...onical.com>, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Matthew Garrett <mjg@...hat.com>
Subject: Re: [PATCH] Add new linearfb driver

On 08/25/2010 01:04 PM, Bruno Prémont wrote:
> On Wed, 25 August 2010 Colin Watson <cjwatson@...onical.com> wrote:
>> Split out linearfb from efifb so that boot loaders can program it as a
>> simple linear framebuffer on non-EFI systems.  This is useful for boot
>> loaders with their own graphics drivers, e.g. GRUB 2, since in some
>> cases on x86 they can set up non-VESA modes and thus can't program
>> vesafb.
>>
>> efifb is reworked on top of this common code, and it should be possible
>> to do the same with some other framebuffer drivers in future.
>>
>> Signed-off-by: Colin Watson <cjwatson@...onical.com>
>> Acked-by: Matthew Garrett <mjg@...hat.com>
>> Cc: Peter Jones <pjones@...hat.com>
>> ---
>>  drivers/video/Kconfig       |   17 ++-
>>  drivers/video/Makefile      |    1 +
>>  drivers/video/efifb.c       |  222 +----------------------------
>>  drivers/video/linearfb.c    |  332 +++++++++++++++++++++++++++++++++++++++++++
>>  include/linux/fb.h          |    8 +
>>  include/linux/screen_info.h |    2 +
>>  6 files changed, 364 insertions(+), 218 deletions(-)
>>  create mode 100644 drivers/video/linearfb.c
>>
>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>> index 59c51d9..a7735ec 100644
>> --- a/drivers/video/Kconfig
>> +++ b/drivers/video/Kconfig
>> @@ -721,13 +721,24 @@ config FB_VESA
>>  	  You will get a boot time penguin logo at no additional cost. Please
>>  	  read <file:Documentation/fb/vesafb.txt>. If unsure, say Y.
>>  
>> -config FB_EFI
>> -	bool "EFI-based Framebuffer Support"
>> -	depends on (FB = y) && X86 && EFI
>> +config FB_LINEAR
>> +	bool "Simple linear framebuffer support"
>> +	depends on FB
>>  	select FB_CFB_FILLRECT
>>  	select FB_CFB_COPYAREA
>>  	select FB_CFB_IMAGEBLIT
>         ^^^^^^^^^^^^^^^^^^^^^^^
> 
>>  	help
>> +	  This is a simple linear frame buffer device driver. It has no
>> +	  hardware-specific programming capability, but must be programmed
>> +	  by the boot loader or by another frame buffer driver.
>> +
>> +	  If unsure, say N.
>> +
>> +config FB_EFI
>> +	bool "EFI-based Framebuffer Support"
>> +	depends on (FB = y) && X86 && EFI
>> +	select FB_LINEAR
>         ^^^^^^^^^^^^^^^^
>   Has kconfig been adjusted to process select recursively?
>   If not the selects from FB_LINEAR will have to be copied here.

This could also be solved by just making it depend on FB_LINEAR instead of
using "select".

-- 
        Peter

I number the Linux folks among my personal heroes.
		-- Donald Knuth

01234567890123456789012345678901234567890123456789012345678901234567890123456789
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/