| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100825201126.GF2738@quack.suse.cz> Date: Wed, 25 Aug 2010 22:11:26 +0200 From: Jan Kara <jack@...e.cz> To: Dave Chinner <david@...morbit.com> Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, jack@...e.cz, npiggin@...nel.dk Subject: Re: [PATCH 0/2] radix-tree: fix writeback livelock avoidance code On Fri 20-08-10 15:22:05, Dave Chinner wrote: > The following two patches fix bugs in the new radix tree functionality used to > implement the writeback livelock avoidance code. Both bugs manifest themselves > as stray PAGECACHE_TAG_TOWRITE tags in the mapping->page_tree radix tree > resulting in livelocks during tag lookups. More subtly, they also appear to > result in writeback tree walks occasionally terminating early and so not > actually writing all the pages they are supposed to. > > Please review and test - these are pretty serious problems for the writeback code. OK, I've updated Andrew's radix tree test suite to use the latest incarnation of radix-tree.c and added check to verify consistency of tags in a radix tree. Without your patches, the new error check triggers almost immediately for radix_tree_range_tag_if_tagged, with them the test passes. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists