linux-kernel - Re: linux-next: Tree for August 25 (mm/slub)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C757D5E.1040307@oracle.com>
Date:	Wed, 25 Aug 2010 13:30:22 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Christoph Lameter <cl@...ux.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>, linux-mm@...ck.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: linux-next: Tree for August 25 (mm/slub)

On 08/25/10 12:07, Christoph Lameter wrote:
> On Wed, 25 Aug 2010, Randy Dunlap wrote:
> 
>> mm/slub.c:1732: error: implicit declaration of function 'slab_pre_alloc_hook'
>> mm/slub.c:1751: error: implicit declaration of function 'slab_post_alloc_hook'
>> mm/slub.c:1881: error: implicit declaration of function 'slab_free_hook'
>> mm/slub.c:1886: error: implicit declaration of function 'slab_free_hook_irq'
> 
> Empty functions are missing if the runtime debuggability option is
> compiled
> out.
> 
> 
> Subject: slub: Add dummy functions for the !SLUB_DEBUG case
> 
> Provide the fall back functions to empty hooks if SLUB_DEBUG is not set.
> 
> Signed-off-by: Christoph Lameter <cl@...ux.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> ---
>  mm/slub.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c	2010-08-25 14:02:43.000000000 -0500
> +++ linux-2.6/mm/slub.c	2010-08-25 14:04:23.000000000 -0500
> @@ -1098,6 +1098,18 @@ static inline void inc_slabs_node(struct
>  							int objects) {}
>  static inline void dec_slabs_node(struct kmem_cache *s, int node,
>  							int objects) {}
> +
> +static inline int slab_pre_alloc_hook(struct kmem_cache *s, gfp_t flags)
> +							{ return 0; }
> +
> +static inline void slab_post_alloc_hook(struct kmem_cache *s, gfp_t flags,
> +		void *object) {}
> +
> +static inline void slab_free_hook(struct kmem_cache *s, void *x) {}
> +
> +static inline void slab_free_hook_irq(struct kmem_cache *s,
> +		void *object) {}
> +
>  #endif
> 
>  /*


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/