linux-kernel - Re: [PATCH] x86: EuroBraille/Iris power off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7588FB.4050001@zytor.com>
Date:	Wed, 25 Aug 2010 14:19:55 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Sebastien Hinderer <Sebastien.Hinderer@...-lyon.org>
CC:	Andreas Mohr <andi@...as.de>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org,
	Samuel Thibault <Samuel.Thibault@...-lyon.org>
Subject: Re: [PATCH] x86: EuroBraille/Iris power off

On 08/25/2010 02:12 PM, Sebastien Hinderer wrote:
> Hi,
> 
>> excellent! Now if as the next step before inclusion you also add the usual DMI check
>> (as done by many drivers such as acerhdf etc.),
>> someone inexperienced who is dumb enough to enable it for his unrelated machine
>> will actually survive an otherwise raw I/O port access and poweroff
>> vector change ;))
> 
> The machine does not support DMI, I have mentionned that in the module.
> 

Perhaps a better questions is: what *do* they have?  I really don't feel
comfortable adding something like this which pokes at a random port in
the ISA range, especially with the Interrupt list listing 6 known other
uses of this particular port.

At that point I'd almost prefer doing something like a BIOS signature
check if we can't do anything better.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/