linux-kernel - Re: [Patch-next] Package Level Power limit: fix the generation of package_power_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100826060822.GA15021@fenghua-desk.sc.intel.com>
Date:	Wed, 25 Aug 2010 23:08:22 -0700
From:	Fenghua Yu <fenghua.yu@...el.com>
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
Cc:	"Yu, Fenghua" <fenghua.yu@...el.com>,
	mingo Redhat <mingo@...hat.com>,
	"Brown, Len" <len.brown@...el.com>,
	Guenter Roeck <guenter.roeck@...csson.com>,
	"H. Peter Anvin" <hpa@...ux.jf.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [Patch-next] Package Level Power limit: fix the generation of
	package_power_limit_count sysfile.

On Wed, Aug 25, 2010 at 07:39:00PM -0700, Jin Dongming wrote:
> 
> This patch is used for fixing it. But I have not confirmed this patch
> because I don't have such machine.
> 
> Signed-off-by: Jin Dongming <jin.dongming@...css.fujitsu.com>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index d9368ee..169d880 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -216,7 +216,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
> err = sysfs_add_file_to_group(&sys_dev->kobj,
> &attr_core_power_limit_count.attr,
> thermal_attr_group.name);
> - if (cpu_has(c, X86_FEATURE_PTS))
> + if (cpu_has(c, X86_FEATURE_PTS)) {
> err = sysfs_add_file_to_group(&sys_dev->kobj,
> &attr_package_throttle_count.attr,
> thermal_attr_group.name);
> @@ -224,6 +224,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
> err = sysfs_add_file_to_group(&sys_dev->kobj,
> &attr_package_power_limit_count.attr,
> thermal_attr_group.name);
> + }
> 
> return err;
> }

The argument is right. A concise message (e.g. missing { and }) would be better.

Format of this patch is broken. It would be applied to kernel tree. Could you
generate a patch with right format?

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/