linux-kernel - Re: [PATCH] Drivers: firewire: Fixed coding style for all the files in the directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1282837273.1875.60.camel@Joe-Laptop>
Date:	Thu, 26 Aug 2010 08:41:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Rotari Razvan-Gabriel <razvanrotari@...il.com>, clemens@...isch.de,
	gregkh@...e.de, tj@...nel.org, dbrownell@...rs.sourceforge.net,
	andre.goddard@...il.com, jkosina@...e.cz, davem@...emloft.net,
	shemminger@...tta.com, eric.dumazet@...il.com,
	martin.petersen@...cle.com, jens.axboe@...cle.com,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: firewire: Fixed coding style for all the
 files in the directory

On Wed, 2010-08-25 at 23:24 +0200, Stefan Richter wrote:
> Rotari Razvan-Gabriel wrote:
[]
> > +++ b/drivers/firewire/core-card.c
> > @@ -107,7 +107,7 @@ static void generate_config_rom(struct fw_card *card, __be32 *config_rom)
> >  	j = 7 + descriptor_count;
> > 
> >  	/* Generate root directory entries for descriptors. */
> > -	list_for_each_entry (desc, &descriptor_list, link) {
> > +	list_for_each_entry(desc, &descriptor_list, link) {
> >  		if (desc->immediate > 0)
> >  			config_rom[i++] = cpu_to_be32(desc->immediate);
> >  		config_rom[i] = cpu_to_be32(desc->key | (j - i));
> 
> Not a fix.

Perhaps you could consider it a consistency change for easier grepping

$ grep -rPoh --include=*.[ch] "\blist_for\w+\s*\(" drivers/firewire | sort | uniq -c
      3 list_for_each_entry (
     21 list_for_each_entry(
     10 list_for_each_entry_safe(



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/