linux-kernel - Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282842125.1875.124.camel@Joe-Laptop>
Date:	Thu, 26 Aug 2010 10:02:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Masayuki Ohtake <masa-korg@....okisemi.com>,
	LKML <linux-kernel@...r.kernel.org>,
	ML netdev <netdev@...r.kernel.org>,
	Greg Rose <gregory.v.rose@...el.com>,
	Maxime Bizon <mbizon@...ebox.fr>,
	Kristoffer Glembo <kristoffer@...sler.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	John Linn <john.linn@...inx.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	"David S. Miller" <davem@...emloft.net>,
	MeeGo <meego-dev@...go.com>, "Wang, Qi" <qi.wang@...el.com>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	Andrew <andrew.chih.howe.khor@...el.com>,
	Intel OTC <joel.clark@...el.com>,
	"Foster, Margie" <margie.foster@...el.com>,
	Toshiharu Okada <okada533@....okisemi.com>,
	Tomoya Morinaga <morinaga526@....okisemi.com>,
	Takahiro Shimizu <shimizu394@....okisemi.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

On Thu, 2010-08-26 at 09:29 -0700, Stephen Hemminger wrote:
> On Thu, 26 Aug 2010 09:16:12 -0700
> Joe Perches <joe@...ches.com> wrote:
> > My message logging order preference:
> > if there's a netif_msg_<type> and a struct net_device
> > 	netif_<level>		(struct private *, netif_msg_<type>,
> > 				 struct net_device *, fmt, args...)
> > if there's a struct net_device
> > 	netdev_<level>		(struct net_device *, fmt, args...)
> > if there's a struct device
> > 	dev_<level>		(struct device *, fmt, args...)
> > otherwise
> > 	pr_<level>		(fmt, args...)
> At this point in process, netdevice isn't registered so it
> doesn't have a ethX name. so dev_info would be best.

Yes, likely true.

Ideally netdev_<level> is used after register_netdev.
The default "eth%d" is printed after alloc_netdev
but before register_netdev.

Before commmit 256df2f3879efdb2e9808bdb1b54b16fbb11fa38
when netdev_<level>s were converted to functions, they
would also dereference a NULL pointer if used before
register_netdev.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/