linux-kernel - Re: [PATCH v2] input: mouse: add qci touchpad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C76B65C.9000702@codeaurora.org>
Date:	Thu, 26 Aug 2010 14:45:48 -0400
From:	Neil Leeder <nleeder@...eaurora.org>
To:	"Datta, Shubhrajyoti" <shubhrajyoti@...com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Horace Fu <horace.fu@...ntatw.com>,
	Mandeep Singh Baines <msb@...omium.org>
Subject: Re: [PATCH v2] input: mouse: add qci touchpad driver

On 8/13/2010 4:36 AM, Datta, Shubhrajyoti wrote:
>
> Minor comments feel free to ignore if you feel so.

Thanks for reviewing this, I'll address these in the next patch.

>> +	err = i2c_master_send(context->ti2c_client, buf, 1);
>> +	if (err<  0)
>> +		goto i2c_fail;
>> +	msleep(100);
> Could you explain the time or have a #define XXX
>
Will add #define

>> +	gpio_direction_input(context->qcitp_gpio);
> The result is not checked here.

I'll check the result.

--
Neil
-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/