linux-kernel - Re: [PATCH] mm: fix hang on anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100826.120002.59671031.davem@davemloft.net>
Date:	Thu, 26 Aug 2010 12:00:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hughd@...gle.com
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	riel@...hat.com, aarcange@...hat.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] mm: fix hang on anon_vma->root->lock

From: Hugh Dickins <hughd@...gle.com>
Date: Thu, 26 Aug 2010 03:54:28 -0700

> On Wed, Aug 25, 2010 at 11:41 PM, David Miller <davem@...emloft.net> wrote:
>> From: Hugh Dickins <hughd@...gle.com>
>> Date: Wed, 25 Aug 2010 23:12:54 -0700 (PDT)
>>
>>> After several hours, kbuild tests hang with anon_vma_prepare() spinning on
>>> a newly allocated anon_vma's lock - on a box with CONFIG_TREE_PREEMPT_RCU=y
>>> (which makes this very much more likely, but it could happen without).
>>>
>>> The ever-subtle page_lock_anon_vma() now needs a further twist: since
>>> anon_vma_prepare() and anon_vma_fork() are liable to change the ->root
>>> of a reused anon_vma structure at any moment, page_lock_anon_vma()
>>> needs to check page_mapped() again before succeeding, otherwise
>>> page_unlock_anon_vma() might address a different root->lock.
>>>
>>> Signed-off-by: Hugh Dickins <hughd@...gle.com>
>>
>> Interesting, is the condition which allows this to trigger specific
>> to this merge window or was it always possible?
> 
> Just specific to this merge window, which started using
> anon_vma->root->lock in place of anon_vma->lock (anon_vma->root is
> often anon_vma itself, but not always).

Ok, because I've been seeing mysterious hangs recently on one of my
sparc64 boxes and I was wondering if this might explain them :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/