[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4C77C20F.1050405@redhat.com>
Date: Fri, 27 Aug 2010 09:47:59 -0400
From: Rik van Riel <riel@...hat.com>
To: Wu Fengguang <fengguang.wu@...el.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
Neil Brown <neilb@...e.de>, Con Kolivas <kernel@...ivas.org>,
Jan Kara <jack@...e.cz>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"david@...morbit.com" <david@...morbit.com>,
"hch@....de" <hch@....de>, "axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio
On 08/27/2010 06:36 AM, Wu Fengguang wrote:
> The dirty_ratio was siliently limited in global_dirty_limits() to>= 5%.
> This is not a user expected behavior. And it's inconsistent with
> calc_period_shift(), which uses the plain vm_dirty_ratio value.
>
> Let's rip the internal bound.
>
> At the same time, fix balance_dirty_pages() to work with the
> dirty_thresh=0 case. This allows applications to proceed when
> dirty+writeback pages are all cleaned.
>
> And ">" fits with the name "exceeded" better than">=" does. Neil
> think it is an aesthetic improvement as well as a functional one :)
>
> CC: Jan Kara<jack@...e.cz>
> CC: Rik van Riel<riel@...hat.com>
> CC: Peter Zijlstra<a.p.zijlstra@...llo.nl>
> Proposed-by: Con Kolivas<kernel@...ivas.org>
> Reviewed-by: Neil Brown<neilb@...e.de>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@...fujitsu.com>
> Signed-off-by: Wu Fengguang<fengguang.wu@...el.com>
Reviewed-by: Rik van Riel <riel@...hat.com>
--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists